make flash: overhaul openocd configuration

Instead of OOCD_SERIAL triggering an attempt to use a specific ftdi based adapter, introduce common target/interface pairs, OOCD_INTERFACE and OOCD_TARGET, and an override via OOCD_FILE allowing full control. Further, attempt to connect to a running openocd instance to flash if possible. This _will not_ work well if you have multiple openocd instances open at once, but that's a rare use case. Examples: OOCD_INTERFACE=stlink-v2 OOCD_TARGET=stm32f0x --> openocd ... -f interface/stlink-v2.cfg -f target/stm32f0x.cfg) OOCD_FILE=board/ek-lm4f120xl.cfg --> openocd ... -f $(OOCD_FILE) (ie, the variable is passed untouched) As part of implementing this, correct variables that were always wrong, and update the openocd flashing commands to use current commands.
2016-04-18 01:14:19 +00:00
parent b227e1609c
commit bcd7d57c11
20 changed files with 33 additions and 38 deletions
--- a/examples/lpc/lpc13xx/Makefile.include
+++ b/examples/lpc/lpc13xx/Makefile.include
@@ -29,7 +29,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS) -mfix-cortex-m3-ldrd

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= lpc13xx

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/lpc/lpc17xx/Makefile.include
+++ b/examples/lpc/lpc17xx/Makefile.include
@@ -30,7 +30,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS) -mfix-cortex-m3-ldrd

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= lpc17xx

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/lpc/lpc43xx/Makefile.include
+++ b/examples/lpc/lpc43xx/Makefile.include
@@ -32,7 +32,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m4 $(FP_FLAGS)

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= lpc4357

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/rules.mk
+++ b/examples/rules.mk
@@ -225,27 +225,21 @@ styleclean: $(STYLECHECKFILES:=.styleclean)

 ifeq ($(STLINK_PORT),)
 ifeq ($(BMP_PORT),)
-ifeq ($(OOCD_SERIAL),)
-%.flash: %.hex
+ifeq ($(OOCD_FILE),)
+%.flash: %.elf
 	@printf "  FLASH   $<\n"
-	@# IMPORTANT: Don't use "resume", only "reset" will work correctly!
-	$(Q)$(OOCD) -f interface/$(OOCD_INTERFACE).cfg \
-		    -f board/$(OOCD_BOARD).cfg \
-		    -c "init" -c "reset init" \
-		    -c "flash write_image erase $(*).hex" \
-		    -c "reset" \
-		    -c "shutdown" $(NULL)
+	$(Q)(echo "halt; program $(*).elf verify reset" | nc -4 localhost 4444 2>/dev/null) || \
+		$(OOCD) -f interface/$(OOCD_INTERFACE).cfg \
+		-f target/$(OOCD_TARGET).cfg \
+		-c "program $(*).elf verify reset exit" \
+		$(NULL)
 else
-%.flash: %.hex
+%.flash: %.elf
 	@printf "  FLASH   $<\n"
-	@# IMPORTANT: Don't use "resume", only "reset" will work correctly!
-	$(Q)$(OOCD) -f interface/$(OOCD_INTERFACE).cfg \
-		    -f board/$(OOCD_BOARD).cfg \
-		    -c "ft2232_serial $(OOCD_SERIAL)" \
-		    -c "init" -c "reset init" \
-		    -c "flash write_image erase $(*).hex" \
-		    -c "reset" \
-		    -c "shutdown" $(NULL)
+	$(Q)(echo "halt; program $(*).elf verify reset" | nc -4 localhost 4444 2>/dev/null) || \
+		$(OOCD) -f $(OOCD_FILE) \
+		-c "program $(*).elf verify reset exit" \
+		$(NULL)
 endif
 else
 %.flash: %.elf
--- a/examples/sam/d/Makefile.include
+++ b/examples/sam/d/Makefile.include
@@ -28,6 +28,6 @@ endif

 OOCD		?= openocd
 OOCD_INTERFACE	?= cmsis-dap
-OOCD_BOARD	?= 
+OOCD_TARGET	?= at91samdXX

 include ../../../../rules.mk
--- a/examples/stm32/f0/Makefile.include
+++ b/examples/stm32/f0/Makefile.include
@@ -28,8 +28,8 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m0 $(FP_FLAGS)
 # OpenOCD specific variables

 OOCD		?= openocd
-OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_INTERFACE	?= stlink-v2-1
+OOCD_TARGET	?= stm32f0x

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/f1/Makefile.include
+++ b/examples/stm32/f1/Makefile.include
@@ -29,7 +29,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS) -mfix-cortex-m3-ldrd

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= stm32f1x

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/f1/obldc/usart_irq/Makefile
+++ b/examples/stm32/f1/obldc/usart_irq/Makefile
@@ -19,7 +19,7 @@

 BINARY = usart_irq

-OOCD_BOARD = open-bldc
+OOCD_FILE = board/open-bldc.cfg

 LDSCRIPT = ../obldc.ld

--- a/examples/stm32/f2/Makefile.include
+++ b/examples/stm32/f2/Makefile.include
@@ -31,7 +31,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS) -mfix-cortex-m3-ldrd

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= stm32f2x

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/f3/Makefile.include
+++ b/examples/stm32/f3/Makefile.include
@@ -30,7 +30,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m4 $(FP_FLAGS)

 OOCD		?= openocd
 OOCD_INTERFACE	?= stlink-v2
-OOCD_BOARD	?= stm32f3discovery
+OOCD_TARGET	?= stm32f3x

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/f4/Makefile.include
+++ b/examples/stm32/f4/Makefile.include
@@ -33,7 +33,7 @@ endif

 OOCD		?= openocd
 OOCD_INTERFACE	?= stlink-v2
-OOCD_BOARD	?= stm32f4discovery
+OOCD_TARGET	?= stm32f4x

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/l0/Makefile.include
+++ b/examples/stm32/l0/Makefile.include
@@ -29,7 +29,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m0plus $(FP_FLAGS)

 OOCD		?= openocd
 OOCD_INTERFACE	?= stlink-v2-1
-OOCD_BOARD	?= stm32l0discovery
+OOCD_TARGET	?= stm32l0

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/stm32/l1/Makefile.include
+++ b/examples/stm32/l1/Makefile.include
@@ -29,7 +29,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS) -mfix-cortex-m3-ldrd

 OOCD		?= openocd
 OOCD_INTERFACE	?= stlink-v2
-OOCD_BOARD	?= stm32ldiscovery
+OOCD_TARGET	?= stm32l1

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/tiva/lm3s/Makefile.include
+++ b/examples/tiva/lm3s/Makefile.include
@@ -29,7 +29,7 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m3 $(FP_FLAGS)

 OOCD		?= openocd
 OOCD_INTERFACE	?= flossjtag
-OOCD_BOARD	?= olimex_stm32_h103
+OOCD_TARGET	?= stellaris

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/tiva/lm4f/Makefile.include
+++ b/examples/tiva/lm4f/Makefile.include
@@ -29,10 +29,11 @@ ARCH_FLAGS	= -mthumb -mcpu=cortex-m4 $(FP_FLAGS)
 # OpenOCD specific variables

 # Support for ICDI is available starting with openocd 0.7.0
+# but a board file maybe required to select jtag/swd transport

 OOCD		?= openocd
 OOCD_INTERFACE	?= ti-icdi
-OOCD_BOARD	?= ek-lm4f120xl
+OOCD_TARGET	?= stellaris

 ################################################################################
 # Black Magic Probe specific variables
--- a/examples/tiva/lm4f/stellaris-ek-lm4f120xl/miniblink/Makefile
+++ b/examples/tiva/lm4f/stellaris-ek-lm4f120xl/miniblink/Makefile
@@ -18,7 +18,7 @@
 ##

 BINARY = miniblink
-
+OOCD_FILE = board/ek-lm4f120xl.cfg
 LDSCRIPT = ../ek-lm4f120xl.ld

 include ../../Makefile.include
--- a/examples/tiva/lm4f/stellaris-ek-lm4f120xl/uart_echo_interrupt/Makefile
+++ b/examples/tiva/lm4f/stellaris-ek-lm4f120xl/uart_echo_interrupt/Makefile
@@ -18,7 +18,7 @@
 ##

 BINARY = uart_echo_interrupt
-
+OOCD_FILE = board/ek-lm4f120xl.cfg
 LDSCRIPT = ../ek-lm4f120xl.ld

 include ../../Makefile.include
--- a/examples/tiva/lm4f/stellaris-ek-lm4f120xl/uart_echo_simple/Makefile
+++ b/examples/tiva/lm4f/stellaris-ek-lm4f120xl/uart_echo_simple/Makefile
@@ -18,7 +18,7 @@
 ##

 BINARY = uart_echo_simple
-
+OOCD_FILE = board/ek-lm4f120xl.cfg
 LDSCRIPT = ../ek-lm4f120xl.ld

 include ../../Makefile.include
--- a/examples/tiva/lm4f/stellaris-ek-lm4f120xl/usb_bulk_dev/Makefile
+++ b/examples/tiva/lm4f/stellaris-ek-lm4f120xl/usb_bulk_dev/Makefile
@@ -18,7 +18,7 @@
 ##

 BINARY = usb_bulk_dev
-
+OOCD_FILE = board/ek-lm4f120xl.cfg
 LDSCRIPT = ../ek-lm4f120xl.ld

 include ../../Makefile.include
--- a/examples/tiva/lm4f/stellaris-ek-lm4f120xl/usb_to_serial_cdcacm/Makefile
+++ b/examples/tiva/lm4f/stellaris-ek-lm4f120xl/usb_to_serial_cdcacm/Makefile
@@ -18,7 +18,7 @@
 ##

 BINARY = usb_to_serial_cdcacm
-
+OOCD_FILE = board/ek-lm4f120xl.cfg
 LDSCRIPT = ../ek-lm4f120xl.ld