From 885d5c610576a7873ae94f0c252fd3de42f33bd9 Mon Sep 17 00:00:00 2001 From: Karl Palsson Date: Thu, 9 Mar 2017 22:31:13 +0000 Subject: [PATCH] stm32: i2c-v2: drop obsolete bit 14 in OAR1 This bit is defined as "maintain at 1" only in v1 peripherals. Drop this bad carryover from v1 code. --- lib/stm32/common/i2c_common_v2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/stm32/common/i2c_common_v2.c b/lib/stm32/common/i2c_common_v2.c index 01180cae..28752535 100644 --- a/lib/stm32/common/i2c_common_v2.c +++ b/lib/stm32/common/i2c_common_v2.c @@ -140,7 +140,6 @@ void i2c_set_own_7bit_slave_address(uint32_t i2c, uint8_t slave) { I2C_OAR1(i2c) = (uint16_t)(slave << 1); I2C_OAR1(i2c) &= ~I2C_OAR1_OA1MODE; - I2C_OAR1(i2c) |= (1 << 14); /* Datasheet: always keep 1 by software. */ } /*---------------------------------------------------------------------------*/ @@ -148,8 +147,6 @@ void i2c_set_own_7bit_slave_address(uint32_t i2c, uint8_t slave) * * This sets an address for Slave mode operation, in 10 bit form. * - * @todo add "I2C_OAR1(i2c) |= (1 << 14);" as above - * * @param[in] i2c Unsigned int32. I2C register base address @ref i2c_reg_base. * @param[in] slave Unsigned int16. Slave address 0...1023. */